Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to force the targetDir to be the bower dir #87

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

KyorCode
Copy link

@KyorCode KyorCode commented Nov 6, 2013

I was getting frustrated managing the targetDir and bower directory ( through bower config ). So I added this option to force the bower directory to be overriden with the targetDir option.

bobbor and others added 5 commits August 21, 2013 17:12
so you can have several (different) bower.json-files in multiple
directories
so that bower also knows where you want your packages to be.
Fixed JSHint errors
@manovotny
Copy link

Would love to see this added! +1

targetDir = path.resolve(options.targetDir);
};

if(options.overrideBoweDirectory){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: missing an "r" in Bower

if(options.overrideBowerDirectory){

@jasonkarns
Copy link

+1 This is the way I expected targetDir to work out of the box. (That is, functioning as if directory were set in .bowerrc.)

@freekode
Copy link

This is one of the most important things for me :) Please make merge this pull request.

@Ninir
Copy link

Ninir commented Jan 9, 2014

@KyorCode Could you fix the issue showed by @cecchi please?
This one would be an awesome one :)

Typo in task fixed
@aesnyder
Copy link

Status on this?

@Ninir
Copy link

Ninir commented Jan 28, 2014

@yatskevich Is it mergeable for you?

@KyorCode
Copy link
Author

KyorCode commented Feb 7, 2014

would be nice to be added. Makes my npm install a bit cleaner

@KyorCode
Copy link
Author

/bump

@mariomc
Copy link

mariomc commented Apr 7, 2014

This is a good feature as it deprecates the need of a ".bowerrc" file in your project directory. Still waiting on news for this PR.

mariomc added a commit to sapo/Ink that referenced this pull request Apr 7, 2014
@AndrewDryga
Copy link

Guys, since author dropped support of this package, i've created new one and merged this pull request into it (among few additional changes): https://github.com/AndrewDryga/grunt-bower-installer

@Nivl
Copy link

Nivl commented Nov 8, 2014

bump

@codewithtyler
Copy link
Collaborator

@AndrewDryga support has not been dropped for this package. With 13 PRs, 49 issues, and a list of things on the roadmap it's just taking some time to get things implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.